Plane: Allow a ICE start even if disable while disarmed is set #25138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WickedShell
commented
Sep 28, 2023
|
@WickedShell doesn't build |
WickedShell
force-pushed
the
wickedshell/engine-disarmed-start
branch
from
4856ab6
to
7eff6f6
Compare
|
Rebased, pulled the MAVLink change in, tested with sending the message from a GCS, as well as through a mission. |
tridge
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to bypass the disable starting while disarmed option in #25053 once. The workflow this enables is as follows:
The main target here is the minimization of risk as we move through the system. When inspecting the fixed wing surfaces we don't want to risk starting the ICE engine, but when we get to starting it we'd actually like to be disarmed, as that stops us from risking taking off by accident or flying the mission.
This had been tested before, but it has since been cherry-picked and rebased, so I need to actually retest this with hardware. This needs an accompanying MAVLink commit to define the usage of param4. (I'm planning to use it as an options bit mask).
Accompanying MAVLink PR is ArduPilot/mavlink#331